test: Add concurrent fixture teardown test for Hypothesis #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankaj-bind
requested review from
asvetlov,
seifertm and
Tinche
as code owners
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
+ Coverage 88.88% 89.38% +0.49%
==========================================
Files 2 2
Lines 405 405
Branches 44 44
==========================================
+ Hits 360 362 +2
+ Misses 35 34 -1
+ Partials 10 9 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seifertm
reviewed
Aug 17, 2025
There was a problem hiding this comment.
Thanks for the contribution.
I'm not sure if the new test is worth adding.
@pankaj-bind Can you explain what prompted you to write it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage for the Hypothesis integration by adding a new test case for concurrent fixture teardowns.
The new
test_hypothesis_concurrent_fixture_teardowntest validates thatasyncfixtures with teardown logic behave correctly when run alongside other concurrent tasks. This helps ensure the robustness ofpytest-asyncio's fixture management in complex, real-world scenarios.To accommodate Hypothesis's health checks for function-scoped fixtures, the test is decorated with
@settings(suppress_health_check=[HealthCheck.function_scoped_fixture]).